Issue 14536002: Fix compiler warning about bool conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14536002: Fix compiler warning about bool conversion. (Closed)

Created:
7 years, 7 months ago by Florian Schneider

Modified:
7 years, 7 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix compiler warning about bool conversion. R=iposva@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22167

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/14536002/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/14536002/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1821 runtime/vm/flow_graph_optimizer.cc:1821: return false; Remove return?

7 years, 7 months ago (2013-04-29 17:06:01 UTC) #2

Florian Schneider

Committed patchset #2 manually as r22167 (presubmit successful).

7 years, 7 months ago (2013-04-30 08:20:52 UTC) #4

Florian Schneider

7 years, 7 months ago (2013-04-30 08:21:11 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/14536002/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/14536002/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1821: return false;
On 2013/04/29 17:06:01, srdjan wrote:
> Remove return?

Done.

Expand Messages | Collapse Messages

Issue 14536002: Fix compiler warning about bool conversion. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages