Issue 14520017: Support a subset of String.format in java2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14520017: Support a subset of String.format in java2dart. (Closed)

Created:
7 years, 8 months ago by nweiz

Modified:
7 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support a subset of String.format in java2dart. This is enough to get analyzer errors formatting, which is very useful for any Dart code using analyzer_experimental. Committed: https://code.google.com/p/dart/source/detail?r=22093

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -2 lines)			Patch
	M	editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart	View		2 chunks	+20 lines, -1 line	0 comments	Download
	M	pkg/analyzer_experimental/lib/src/generated/java_core.dart	View		1 chunk	+12 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM after missing exception declaration fix. https://codereview.chromium.org/14520017/diff/1/pkg/analyzer_experimental/lib/src/generated/java_core.dart File pkg/analyzer_experimental/lib/src/generated/java_core.dart (right): https://codereview.chromium.org/14520017/diff/1/pkg/analyzer_experimental/lib/src/generated/java_core.dart#newcode139 pkg/analyzer_experimental/lib/src/generated/java_core.dart:139: throw new MissingFormatArgumentException(match.group(0)); ...

7 years, 8 months ago (2013-04-26 22:37:41 UTC) #2

nweiz

Committed patchset #1 manually as r22093 (presubmit successful).

7 years, 8 months ago (2013-04-26 22:43:23 UTC) #3

nweiz

7 years, 8 months ago (2013-04-26 23:13:37 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14520017/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/generated/java_core.dart (right):

https://codereview.chromium.org/14520017/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/generated/java_core.dart:139: throw new
MissingFormatArgumentException(match.group(0));
On 2013/04/26 22:37:41, scheglov wrote:
> Do you want to copy declaration of this exception into generated file too?

Done.

Expand Messages | Collapse Messages