First step towards loading the core library scripts directly from the sources

First step towards loading the core library scripts directly from the sources
instead of concatenating all the scripts and linking them into the executable.
- Refactor the bootstrap script loading and compilation part to use a
  custom bootstrap library tag handler

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22154

[Ivan Posva, 2013-04-29 04:42:32]

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc
File runtime/vm/bootstrap.cc (right):

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:27: const char* url_;
We should use URI instead of URL. I know that will add inconsistencies in
naming, but I don't think we should add more usage of URL.

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:31: } bootstrap_lib_props;
Empty lines.

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:110: Dart_Handle
BootStrapLibraryTagHandler(Dart_LibraryTag tag,
BootstrapLibraryTagHandler?

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:133: // We expect the core boot strap libraries to only
import other
bootstrap
Here and below to be consistent.

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:183: error = Bootstrap::Compile(lib, core_script);
Why is core special here? Can't we add it to the list of bootstrap libraries?

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:232: RawScript* Bootstrap::LoadCoreScript() {
What is this still needed for?

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/object.cc#newco...
runtime/vm/object.cc:680: #define LOAD_LIBRARY(name, raw_name)                  
                        \
This is now an empty macro.

[siva, 2013-04-29 17:35:58]

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc
File runtime/vm/bootstrap.cc (right):

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:27: const char* url_;
On 2013/04/29 04:42:32, Ivan Posva wrote:
> We should use URI instead of URL. I know that will add inconsistencies in
> naming, but I don't think we should add more usage of URL.

Done.

I have only changed the name in these changes and did not try a global change.

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:31: } bootstrap_lib_props;
On 2013/04/29 04:42:32, Ivan Posva wrote:
> Empty lines.

Done.

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:110: Dart_Handle
BootStrapLibraryTagHandler(Dart_LibraryTag tag,
On 2013/04/29 04:42:32, Ivan Posva wrote:
> BootstrapLibraryTagHandler?

Done.

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:133: // We expect the core boot strap libraries to only
import other
On 2013/04/29 04:42:32, Ivan Posva wrote:
> bootstrap
> Here and below to be consistent.

Done.

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:183: error = Bootstrap::Compile(lib, core_script);
We precreate the core script in Object::Init so that we can set the script field
for all the core classes
(instance, int, double, string, list) that we precreate before any of the
scripts are compiled.

Hence over here we do not try to create another script object instead we just
use that object and just compile it.

On 2013/04/29 04:42:32, Ivan Posva wrote:
> Why is core special here? Can't we add it to the list of bootstrap libraries?

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/bootstrap.cc#ne...
runtime/vm/bootstrap.cc:232: RawScript* Bootstrap::LoadCoreScript() {
See comment above about.

Maybe I should investigate if that whole code in Object::Init can be done
without setting the script.

On 2013/04/29 04:42:32, Ivan Posva wrote:
> What is this still needed for?

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/14520010/diff/5003/runtime/vm/object.cc#newco...
runtime/vm/object.cc:680: #define LOAD_LIBRARY(name, raw_name)                  
                        \
Yes, removed it.

On 2013/04/29 04:42:32, Ivan Posva wrote:
> This is now an empty macro.

[siva, 2013-04-29 20:22:20]

I have made the change to get rid of LoadCoreScript and
unified dart:core into the list of bootstrap libaries.

PTAL

[Ivan Posva, 2013-04-29 21:13:47]

LGTM -ip

https://codereview.chromium.org/14520010/diff/15002/runtime/vm/bootstrap.cc
File runtime/vm/bootstrap.cc (right):

https://codereview.chromium.org/14520010/diff/15002/runtime/vm/bootstrap.cc#n...
runtime/vm/bootstrap.cc:107: Dart_Handle
BootstrapLibraryTagHandler(Dart_LibraryTag tag,
static

https://codereview.chromium.org/14520010/diff/15002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/14520010/diff/15002/runtime/vm/object.cc#newc...
runtime/vm/object.cc:824: // class with no associated source code.
Although the methods associated with this class will get a proper script and
token offsets assigned, no?

[siva, 2013-04-29 21:47:38]

https://codereview.chromium.org/14520010/diff/15002/runtime/vm/bootstrap.cc
File runtime/vm/bootstrap.cc (right):

https://codereview.chromium.org/14520010/diff/15002/runtime/vm/bootstrap.cc#n...
runtime/vm/bootstrap.cc:107: Dart_Handle
BootstrapLibraryTagHandler(Dart_LibraryTag tag,
On 2013/04/29 21:13:47, Ivan Posva wrote:
> static

Done.

https://codereview.chromium.org/14520010/diff/15002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/14520010/diff/15002/runtime/vm/object.cc#newc...
runtime/vm/object.cc:824: // class with no associated source code.
True.

I changed the commend to reflect that.

On 2013/04/29 21:13:47, Ivan Posva wrote:
> Although the methods associated with this class will get a proper script and
> token offsets assigned, no?

[siva, 2013-04-29 22:00:25]

Committed patchset #8 manually as r22154 (presubmit successful).