Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 14499010: Make ninja build on mac work (Closed)

Created:
7 years, 7 months ago by kustermann
Modified:
7 years, 7 months ago
Reviewers:
ricow1, Bill Hesse, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make ninja build on mac work If we use ninja as gyp backend on mac, all configurations must have the same xcode_settings. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22173

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M runtime/bin/net/ssl.gyp View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
This CL enables us to use ninja for building dart on mac. If anybody knows ...
7 years, 7 months ago (2013-04-29 11:09:28 UTC) #1
Bill Hesse
lgtm https://codereview.chromium.org/14499010/diff/1/runtime/bin/net/ssl.gyp File runtime/bin/net/ssl.gyp (right): https://codereview.chromium.org/14499010/diff/1/runtime/bin/net/ssl.gyp#newcode162 runtime/bin/net/ssl.gyp:162: 'inherit_from': ['Dart_Base'], Please comment this as a modification ...
7 years, 7 months ago (2013-04-29 11:17:54 UTC) #2
kustermann
https://codereview.chromium.org/14499010/diff/1/runtime/bin/net/ssl.gyp File runtime/bin/net/ssl.gyp (right): https://codereview.chromium.org/14499010/diff/1/runtime/bin/net/ssl.gyp#newcode162 runtime/bin/net/ssl.gyp:162: 'inherit_from': ['Dart_Base'], On 2013/04/29 11:17:54, Bill Hesse wrote: > ...
7 years, 7 months ago (2013-04-30 10:37:22 UTC) #3
kustermann
7 years, 7 months ago (2013-04-30 10:38:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22173 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698