Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Issue 14493015: Add HTTP proxy tunnel support (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 7 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add HTTP proxy tunnel support The HTTP client will now use the CONNECT method with a proxy server for all HTTPS requests. The CONNECT method will establish a tunnel and a TLS end-to-end connection will then be created through that tunnel. The previous method of sending a HTTPS url as the request URI is no longer supported. Also it is not possible to configure normal HTTP requests to go through a tunnel created with CONNECT. All HTTP requests use the normal procedure when going through a proxy. Add the ability to specify a host name when creating a secure sonnection on top of a non-secure one. This is required for a proxy tunnel as the initial connection is to a different host as the one the TLS connection will be with. R=ager@google.com BUG=https://code.google.com/p/dart/issues/detail?id=5468 Committed: https://code.google.com/p/dart/source/detail?r=22119

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -57 lines) Patch
M sdk/lib/io/http_impl.dart View 8 chunks +81 lines, -14 lines 1 comment Download
M sdk/lib/io/secure_socket.dart View 4 chunks +11 lines, -3 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 3 chunks +44 lines, -33 lines 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 4 chunks +25 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 8 months ago (2013-04-25 14:55:32 UTC) #1
Mads Ager (google)
LGTM https://codereview.chromium.org/14493015/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/14493015/diff/1/sdk/lib/io/http_impl.dart#newcode1335 sdk/lib/io/http_impl.dart:1335: if (uri.domain.isEmpty || (uri.scheme != "http" && uri.scheme ...
7 years, 7 months ago (2013-04-29 10:05:01 UTC) #2
Søren Gjesse
7 years, 7 months ago (2013-04-29 13:30:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22119 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698