Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 14487008: When a phi is generated at use site, the names of its inputs must be freed by the user of the phi. (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

When a phi is generated at use site, the names of its inputs must be freed by the user of the phi. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=22118

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A tests/language/issue10204_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 7 months ago (2013-04-29 13:10:49 UTC) #1
kasperl
LGTM!
7 years, 7 months ago (2013-04-29 13:12:55 UTC) #2
ngeoffray
7 years, 7 months ago (2013-04-29 13:13:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698