Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 14477015: Revert "Use clang on mac if XCode >= 4.5" (Closed)

Created:
7 years, 8 months ago by kustermann
Modified:
7 years, 8 months ago
Reviewers:
hausner, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Use clang on mac if XCode >= 4.5" We cannot build v8 after this change because clang reports a warning in v8/src/parser.cc about an unused field (and we turn warnings into errors). We can enable this change again after we update to a new v8 version (this seems to be fixed in v3.17). Committed: https://code.google.com/p/dart/source/detail?r=21984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M tools/gyp/find_mac_gcc_version.py View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
7 years, 8 months ago (2013-04-24 21:04:14 UTC) #1
hausner
lgtm
7 years, 8 months ago (2013-04-24 21:05:03 UTC) #2
kustermann
7 years, 8 months ago (2013-04-24 21:05:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21984 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698