fix for cache list to handle old cached packages with sdk dependencies

fix for cache list to handle old cached packages with sdk dependencies

Committed: https://code.google.com/p/dart/source/detail?r=21995

[Bob Nystrom, 2013-04-24 21:16:41]

https://codereview.chromium.org/14476013/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/hosted_source.dart (right):

https://codereview.chromium.org/14476013/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/hosted_source.dart:133: // sdk dependency, fix to
parse and report usage of sdk dependency.
Can you file a bug for this and mention the bug number here?

https://codereview.chromium.org/14476013/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/hosted_source.dart:136: } catch (e){
Space before "{".

Also, let's restrict this to the error we expect, so:

} on ApplicationException catch (e) {

That way we don't mask unexpected errors.

[keertip, 2013-04-24 21:25:29]

https://codereview.chromium.org/14476013/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/hosted_source.dart (right):

https://codereview.chromium.org/14476013/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/hosted_source.dart:133: // sdk dependency, fix to
parse and report usage of sdk dependency.
On 2013/04/24 21:16:41, Bob Nystrom wrote:
> Can you file a bug for this and mention the bug number here?

Done.

https://codereview.chromium.org/14476013/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/hosted_source.dart:136: } catch (e){
Done.

On 2013/04/24 21:16:41, Bob Nystrom wrote:
> Space before "{".
> 
> Also, let's restrict this to the error we expect, so:
> 
> } on ApplicationException catch (e) {
> 
> That way we don't mask unexpected errors.

Done.

[Bob Nystrom, 2013-04-24 22:14:28]

LGTM.

[keertip, 2013-04-24 23:56:00]

Committed patchset #2 manually as r21995 (presubmit successful).