Enable api tests on ARM.

Enable api tests on ARM.
Disable generation of optimized code on ARM and MIPS.

Committed: https://code.google.com/p/dart/source/detail?r=21972

[srdjan, 2013-04-24 17:32:35]

DBC

https://codereview.chromium.org/14476009/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/14476009/diff/1/runtime/tests/vm/vm.status#ne...
runtime/tests/vm/vm.status:66: cc/LazyLoadDeoptimizes: Skip
I would recommend activating these tests and disabling generating optimized for
ARM and MIPS.

[regis, 2013-04-24 17:42:17]

Good idea. Both tests now pass after disabling generation of optimized code.

Thanks,
Regis

https://codereview.chromium.org/14476009/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/14476009/diff/1/runtime/tests/vm/vm.status#ne...
runtime/tests/vm/vm.status:66: cc/LazyLoadDeoptimizes: Skip
On 2013/04/24 17:32:35, srdjan wrote:
> I would recommend activating these tests and disabling generating optimized
for
> ARM and MIPS.

Done.

[zra, 2013-04-24 18:22:26]

LGTM with comments and question.

https://codereview.chromium.org/14476009/diff/11/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/14476009/diff/11/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:170: #endif
A comment here will make it easier for me to find and remove it later.

https://codereview.chromium.org/14476009/diff/11/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:242: #endif
And here. Others follow.

https://codereview.chromium.org/14476009/diff/11/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/14476009/diff/11/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm.cc:1151: if (obj.IsSmi() &&
(Smi::Cast(obj).Value() == 0)) {
Why only the 0 case?

[regis, 2013-04-24 18:40:47]

Thanks!

https://codereview.chromium.org/14476009/diff/11/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/14476009/diff/11/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:170: #endif
On 2013/04/24 18:22:26, zra wrote:
> A comment here will make it easier for me to find and remove it later.

Done.

https://codereview.chromium.org/14476009/diff/11/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:242: #endif
On 2013/04/24 18:22:26, zra wrote:
> And here. Others follow.

Done.

https://codereview.chromium.org/14476009/diff/11/runtime/vm/flow_graph_compil...
File runtime/vm/flow_graph_compiler_arm.cc (right):

https://codereview.chromium.org/14476009/diff/11/runtime/vm/flow_graph_compil...
runtime/vm/flow_graph_compiler_arm.cc:1151: if (obj.IsSmi() &&
(Smi::Cast(obj).Value() == 0)) {
On 2013/04/24 18:22:26, zra wrote:
> Why only the 0 case?

This is an optimization copied from the Intel side. If the object is constant
zero, then 'tst reg, reg' will yield 'EQUAL' only if it is also zero.
Otherwise, the cmp instruction is used with a 32-bit immediate value on Intel.
It is true that it makes no difference on ARM, since a 'cmp reg, #0' is as
efficient as a 'tst reg, reg'.
So I removed it. Thanks.

[regis, 2013-04-24 18:55:58]

Committed patchset #3 manually as r21972 (presubmit successful).