Preserve aggregate count when creating unary checks ICData.

Preserve aggregate count when creating unary checks ICData.

We were reseting it to 1 which leads to worse inlining decisions for example for user defined binary operators. Inliner considered them all cold.

R=srdjan@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21964

[srdjan, 2013-04-24 17:16:44]

LGTM

https://codereview.chromium.org/14474007/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/14474007/diff/1/runtime/vm/object.cc#newcode8347
runtime/vm/object.cc:8347: if (count == Smi::kMaxValue) {
Why not:

if (count < Smi::kMaxValue) {
  SetCountAt(
}

[Vyacheslav Egorov (Google), 2013-04-24 17:50:32]

Thanks for the review. Landing.

https://codereview.chromium.org/14474007/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/14474007/diff/1/runtime/vm/object.cc#newcode8347
runtime/vm/object.cc:8347: if (count == Smi::kMaxValue) {
On 2013/04/24 17:16:44, srdjan wrote:
> Why not:
> 
> if (count < Smi::kMaxValue) {
>   SetCountAt(
> }

Done.

[Vyacheslav Egorov (Google), 2013-04-24 17:51:24]

Committed patchset #2 manually as r21964 (presubmit successful).