Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14469002: Add new InternetAddress class with a static lookup function (including IPv6 (Closed)

Created:
7 years, 8 months ago by Anders Johnsen
Modified:
7 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add new InternetAddress class with a static lookup function (including IPv6 results). Reapply of https://codereview.chromium.org/13880029/ with fixes. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21934

Patch Set 1 #

Patch Set 2 : Introduce RawAddr as our internal sockaddr type. #

Patch Set 3 : Win support #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+822 lines, -441 lines) Patch
M pkg/http/test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection.cc View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/bin/secure_socket.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M runtime/bin/socket.h View 1 4 chunks +92 lines, -5 lines 0 comments Download
M runtime/bin/socket.cc View 1 5 chunks +66 lines, -17 lines 0 comments Download
M runtime/bin/socket_android.cc View 1 2 3 6 chunks +68 lines, -63 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 6 chunks +65 lines, -60 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 2 3 6 chunks +65 lines, -56 lines 0 comments Download
M runtime/bin/socket_patch.dart View 8 chunks +108 lines, -49 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 2 3 7 chunks +76 lines, -71 lines 0 comments Download
M runtime/bin/vmstats_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/secure_socket.dart View 10 chunks +20 lines, -12 lines 0 comments Download
M sdk/lib/io/socket.dart View 6 chunks +83 lines, -8 lines 0 comments Download
M tests/standalone/io/http_close_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/http_compression_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_keep_alive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 12 chunks +13 lines, -13 lines 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/https_client_certificate_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/https_client_exception_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/standalone/io/https_server_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/raw_secure_server_closing_test.dart View 5 chunks +4 lines, -5 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 6 chunks +8 lines, -9 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_pause_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_client_raw_server_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_client_server_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_multiple_client_server_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M tests/standalone/io/secure_server_closing_test.dart View 5 chunks +4 lines, -5 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 6 chunks +7 lines, -8 lines 0 comments Download
M tests/standalone/io/secure_session_resume_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_socket_bad_certificate_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/standalone/io/socket_ipv6_test.dart View 1 chunk +88 lines, -0 lines 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
PTAL. win/mac/android will follow if we are happy :)
7 years, 8 months ago (2013-04-24 08:49:38 UTC) #1
Søren Gjesse
LGTM
7 years, 8 months ago (2013-04-24 08:52:45 UTC) #2
Anders Johnsen
PTAL, mac/android/win update.
7 years, 8 months ago (2013-04-24 09:19:57 UTC) #3
Søren Gjesse
LGTM I think we should rename RawAddr, but let's postpone that. Also the SocketAddress constructor ...
7 years, 8 months ago (2013-04-24 09:25:03 UTC) #4
Anders Johnsen
7 years, 8 months ago (2013-04-24 09:27:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as r21934 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698