Issue 14455007: Refactoring DOM annotations and comment generation, adding DOM API triage list

Issue 14455007: Refactoring DOM annotations and comment generation, adding DOM API triage list (Closed)

Created:
7 years, 8 months ago by blois

Modified:
7 years, 7 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactoring DOM annotations and comment generation, adding DOM API triage list This pulls the annotation and comment code out of generator.py and into a Metadata class, which is also tracking new APIs from the IDLs. Right now the API triage list is being updated when new members appear, but is not adding any metadata to the Dart APIs. Of note for the triage list is that there are currently 437 untriaged members- these are all of the APIs which have either been introduced, renamed or moved in the past week. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22193

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12208 lines, -808 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	35 chunks	+0 lines, -170 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	12 chunks	+0 lines, -50 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	7 chunks	+0 lines, -32 lines	0 comments	Download
M	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View	4 chunks	+0 lines, -30 lines	0 comments	Download
A	tools/dom/dom.json	View	1 chunk	+11576 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/dartdomgenerator.py	View	6 chunks	+15 lines, -5 lines	0 comments	Download
A	tools/dom/scripts/dartmetadata.py	View	1 chunk	+562 lines, -0 lines	1 comment	Download
M	tools/dom/scripts/generator.py	View	2 chunks	+0 lines, -466 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	9 chunks	+17 lines, -18 lines	0 comments	Download
M	tools/dom/scripts/htmleventgenerator.py	View	4 chunks	+7 lines, -8 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	10 chunks	+21 lines, -21 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	3 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm https://chromiumcodereview.appspot.com/14455007/diff/1/tools/dom/scripts/dartmetadata.py File tools/dom/scripts/dartmetadata.py (right): https://chromiumcodereview.appspot.com/14455007/diff/1/tools/dom/scripts/dartmetadata.py#newcode557 tools/dom/scripts/dartmetadata.py:557: return '@Deprecated' else raise error?

7 years, 7 months ago (2013-04-30 01:29:43 UTC) #2

blois

7 years, 7 months ago (2013-04-30 18:35:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22193 (presubmit successful).

Expand Messages | Collapse Messages