Issue 14449009: Another fix for debugging stack traces and captured variables.

Issue 14449009: Another fix for debugging stack traces and captured variables. (Closed)

Created:
7 years, 7 months ago by hausner

Modified:
7 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Another fix for debugging stack traces and captured variables. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22196

Patch Set 3 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -13 lines)			Patch
M	runtime/vm/compiler.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2	3 chunks	+32 lines, -3 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/scopes.cc	View	1 2	1 chunk	+13 lines, -3 lines	0 comments	Download
M	tools/ddbg.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/14449009/diff/5001/runtime/vm/debugger.h File runtime/vm/debugger.h (right): https://codereview.chromium.org/14449009/diff/5001/runtime/vm/debugger.h#newcode162 runtime/vm/debugger.h:162: RawContext* GetSavedCallerContext(const Context& ctx); I would call this ...

7 years, 7 months ago (2013-04-30 18:46:50 UTC) #2

hausner

Thank you. https://codereview.chromium.org/14449009/diff/5001/runtime/vm/debugger.h File runtime/vm/debugger.h (right): https://codereview.chromium.org/14449009/diff/5001/runtime/vm/debugger.h#newcode162 runtime/vm/debugger.h:162: RawContext* GetSavedCallerContext(const Context& ctx); On 2013/04/30 18:46:50, ...

7 years, 7 months ago (2013-04-30 19:38:54 UTC) #3

hausner

7 years, 7 months ago (2013-04-30 19:46:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r22196 (presubmit successful).

Expand Messages | Collapse Messages