Issue 144473004: Make _Utf8Encoder create its buffer through an external function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144473004: Make _Utf8Encoder create its buffer through an external function. (Closed)

Created:
6 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 10 months ago

Reviewers:
Florian Schneider, floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make _Utf8Encoder create its buffer through an external function. This allows the VM to use a Uint8List, where dart2js still has to use a plain List (due to versions of IE not supporting typed data). R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32193

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -18 lines)			Patch
M	runtime/lib/convert_patch.dart	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/service_test.cc	View		8 chunks	+16 lines, -16 lines	0 comments	Download
M	sdk/lib/_internal/lib/convert_patch.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/convert/utf.dart	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! thanks. https://codereview.chromium.org/144473004/diff/1/sdk/lib/convert/utf.dart File sdk/lib/convert/utf.dart (right): https://codereview.chromium.org/144473004/diff/1/sdk/lib/convert/utf.dart#newcode136 sdk/lib/convert/utf.dart:136: // TODO(11971, floitsch): use Uint8List instead of ...

6 years, 10 months ago (2014-01-31 13:03:49 UTC) #2

Lasse Reichstein Nielsen

6 years, 10 months ago (2014-01-31 13:11:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r32193 (presubmit successful).

Expand Messages | Collapse Messages