Issue 14447008: Fix for mirror API breaking change to index libraries by URI, and clean up references in doc commen…

Issue 14447008: Fix for mirror API breaking change to index libraries by URI, and clean up references in doc commen… (Closed)

Created:
7 years, 8 months ago by Alan Knight

Modified:
7 years, 8 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for mirror API breaking change to index libraries by URI, and clean up references in doc comments Committed: https://code.google.com/p/dart/source/detail?r=22040

Patch Set 2 : Merged up to date #

Patch Set 3 : Removed a print statement, one unsaved fix. #

Total comments: 2

Patch Set 4 : Fix from review #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -29 lines)			Patch
M	pkg/serialization/lib/serialization.dart	View	1 2	5 chunks	+18 lines, -13 lines	0 comments	Download
M	pkg/serialization/lib/src/basic_rule.dart	View	1 2 3	5 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/serialization/lib/src/format.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/serialization/lib/src/reader_writer.dart	View	1 2 3	4 chunks	+6 lines, -4 lines	0 comments	Download
M	pkg/serialization/lib/src/serialization_rule.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/serialization/test/serialization_test.dart	View		2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/14447008/diff/3003/pkg/serialization/lib/src/basic_rule.dart File pkg/serialization/lib/src/basic_rule.dart (right): https://codereview.chromium.org/14447008/diff/3003/pkg/serialization/lib/src/basic_rule.dart#newcode614 pkg/serialization/lib/src/basic_rule.dart:614: * [_FieldList._contents], which will be alphabetically sorted. probably ...

7 years, 8 months ago (2013-04-24 20:23:05 UTC) #2

Alan Knight

Committed patchset #4 manually as r22040 (presubmit successful).

7 years, 8 months ago (2013-04-25 16:49:44 UTC) #3

Alan Knight

7 years, 8 months ago (2013-04-25 16:50:18 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14447008/diff/3003/pkg/serialization/lib/src/...
File pkg/serialization/lib/src/basic_rule.dart (right):

https://codereview.chromium.org/14447008/diff/3003/pkg/serialization/lib/src/...
pkg/serialization/lib/src/basic_rule.dart:614: * [_FieldList._contents], which
will be alphabetically sorted.
On 2013/04/24 20:23:05, John Messerly wrote:
> probably don't want to refer to a private member, since this link won't work
in
> the docs?

Done.

Expand Messages | Collapse Messages