Issue 14446005: Enables stack frame vm tests on MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14446005: Enables stack frame vm tests on MIPS. (Closed)

Created:
7 years, 8 months ago by zra

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enables stack frame vm tests on MIPS. Committed: https://code.google.com/p/dart/source/detail?r=21906

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -46 lines)			Patch
M	runtime/vm/flow_graph_compiler_mips.cc	View		1 chunk	+55 lines, -2 lines	0 comments	Download
M	runtime/vm/stack_frame_mips.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/stack_frame_test.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1	3 chunks	+82 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/14446005/diff/1/runtime/vm/stub_code_mips.cc File runtime/vm/stub_code_mips.cc (right): https://codereview.chromium.org/14446005/diff/1/runtime/vm/stub_code_mips.cc#newcode1657 runtime/vm/stub_code_mips.cc:1657: __ mov(RA, A0); // Program counter. Can't you ...

7 years, 8 months ago (2013-04-23 21:26:05 UTC) #2

zra

Thanks! https://codereview.chromium.org/14446005/diff/1/runtime/vm/stub_code_mips.cc File runtime/vm/stub_code_mips.cc (right): https://codereview.chromium.org/14446005/diff/1/runtime/vm/stub_code_mips.cc#newcode1657 runtime/vm/stub_code_mips.cc:1657: __ mov(RA, A0); // Program counter. On 2013/04/23 ...

7 years, 8 months ago (2013-04-23 21:42:09 UTC) #3

zra

7 years, 8 months ago (2013-04-23 21:42:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21906 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14446005: Enables stack frame vm tests on MIPS. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages