Issue 14436004: Add a new test suite 'analyze_tests'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14436004: Add a new test suite 'analyze_tests' (Closed)

Created:
7 years, 8 months ago by Søren Gjesse

Modified:
7 years, 8 months ago

Reviewers:
ricow1, Anders Johnsen, Mads Ager (google), kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a new test suite 'analyze_tests' The new test suite 'analyze_tests' will run the analyzer on the selected tests, and fail if there are static type errors. Currently only the tests in tests/standalone are included, but that can easily be expanded. The reason for starting this was that for M4 we where missing two 'part' files in io.dart (for the HttpBody utility class). This caused the use of HttpBody in the editor to be complicated. With static type checking on the tests which tested HttpBody this mistake would have been caught. R=ager@google.com, ricow@google.com, kustermann@google.com, ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21944

Patch Set 1 #

Patch Set 2 : Fixed a test with type errors #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -3 lines)			Patch
A	tests/lib/analyzer/analyze_tests.status	View		1 chunk	+38 lines, -0 lines	0 comments	Download
M	tests/lib/analyzer/test_config.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/test.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years, 8 months ago (2013-04-24 12:47:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21944 (presubmit successful).

Expand Messages | Collapse Messages