Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 14432004: Inline Float32x4 min,max,sqrt,reciprocal,reciprocalSqrt, and scale (Closed)

Created:
7 years, 7 months ago by Cutch
Modified:
7 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Inline Float32x4 min,max,sqrt,reciprocal,reciprocalSqrt, and scale R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22185

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+523 lines, -9 lines) Patch
runtime/vm/flow_graph_optimizer.cc View 1 2 2 chunks +66 lines, -0 lines 0 comments Download
runtime/vm/flow_graph_type_propagator.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +22 lines, -0 lines 0 comments Download
runtime/vm/intermediate_language.h View 1 2 5 chunks +166 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
runtime/vm/intermediate_language_ia32.cc View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
runtime/vm/intermediate_language_mips.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
runtime/vm/intermediate_language_x64.cc View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
M tests/lib/typed_data/float32x4_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
7 years, 7 months ago (2013-04-29 22:50:06 UTC) #1
Cutch
On 2013/04/29 22:50:06, Cutch wrote: ./tools/test.py -m all -a all --checked Test configurations: none_vm_debug_ia32_checked none_vm_release_ia32_checked ...
7 years, 7 months ago (2013-04-29 22:59:52 UTC) #2
srdjan
lgtm
7 years, 7 months ago (2013-04-30 16:00:13 UTC) #3
Cutch
7 years, 7 months ago (2013-04-30 17:26:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r22185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698