Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 14426010: Fix debugging of top-level getters (Closed)

Created:
7 years, 8 months ago by hausner
Modified:
7 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, devoncarew, Alan Knight
Visibility:
Public.

Description

Fix debugging of top-level getters Parser didn't set the valid token range of top-level getters, so they were invisible to the debugger. Committed: https://code.google.com/p/dart/source/detail?r=21976

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/parser.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 8 months ago (2013-04-24 00:13:50 UTC) #1
hausner
7 years, 8 months ago (2013-04-24 19:53:31 UTC) #2
regis
LGTM
7 years, 8 months ago (2013-04-24 20:03:57 UTC) #3
hausner
7 years, 8 months ago (2013-04-24 20:26:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698