Issue 14424009: Fixing more fingerprints. What is the right way to find all of these?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14424009: Fixing more fingerprints. What is the right way to find all of these? (Closed)

Created:
7 years, 8 months ago by Mads Ager (google)

Modified:
7 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing more fingerprints. What is the right way to find all of these? R=srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21877

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/intermediate_language.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Mads Ager (google)

Committed patchset #1 manually as r21877 (presubmit successful).

7 years, 8 months ago (2013-04-23 12:41:18 UTC) #2

srdjan

7 years, 8 months ago (2013-04-23 16:03:00 UTC) #3

Message was sent while issue was closed.

LGTM

The right way is to use --check-function-fingerprint

See email sent to dart VM team:
FYI: r21711 adds to VM --check-function-fingerprint