Issue 144053002: Fix bug in flow-graph loop detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144053002: Fix bug in flow-graph loop detection. (Closed)

Created:
6 years, 11 months ago by Florian Schneider

Modified:
6 years, 11 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug in flow-graph loop detection. With OSR there can be multiple loops that share one common loop header. These loops must be treated as one loop, otherwise side effects are not correctly computed. BUG=dartbug.com/16151 TEST=language/osr_test R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31956

Patch Set 1 #

Patch Set 2 : updated co19 status file #

Patch Set 3 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -14 lines)			Patch
M	runtime/vm/flow_graph.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph.cc	View		3 chunks	+28 lines, -10 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

6 years, 11 months ago (2014-01-21 16:02:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r31956 (presubmit successful).

Expand Messages | Collapse Messages