Revert "- Do not keep growing when creating Lists from Iterables."

Revert "- Do not keep growing when creating Lists from Iterables."

This reverts commit r21531.

BUG= http://dartbug.com/10070

Committed: https://code.google.com/p/dart/source/detail?r=21817

[floitsch, 2013-04-22 16:49:32]

Reverting r21531. The CL broke toList of WhereIterables and generally changed
the semantics of Iterable.toList and List.from.

@Ivan: Please include Lasse or me when you do core library changes.

[Vyacheslav Egorov (Google), 2013-04-22 16:51:16]

rubberstamp lgtm

[floitsch, 2013-04-22 16:53:25]

Committed patchset #1 manually as r21817 (presubmit successful).

[siva, 2013-04-23 06:30:32]

On 2013/04/22 16:53:25, floitsch wrote:
> Committed patchset #1 manually as r21817 (presubmit successful).

Is toList broken because we end up iterating twice inside toList?

[Ivan Posva, 2013-04-23 06:38:50]

On 2013/04/23 06:30:32, siva wrote:
> On 2013/04/22 16:53:25, floitsch wrote:
> > Committed patchset #1 manually as r21817 (presubmit successful).
> 
> Is toList broken because we end up iterating twice inside toList?

I would also like to understand what was broken here.

Thanks,
-Ivan

[floitsch, 2013-04-23 09:19:49]

On 2013/04/23 06:30:32, siva wrote:
> On 2013/04/22 16:53:25, floitsch wrote:
> > Committed patchset #1 manually as r21817 (presubmit successful).
> 
> Is toList broken because we end up iterating twice inside toList?

Yes.
We recommend users to use "toList" to become non-lazy.
[1, 2, 3].where((x) => foo(x)).toList()

If foo has a side-effect then toList will execute foo twice on every element.