Use UnmodifiableListView to expose read-only lists.

Use UnmodifiableListView to expose read-only lists.

Committed: https://code.google.com/p/dart/source/detail?r=21855

[Bob Nystrom, 2013-04-22 22:11:40]

https://codereview.chromium.org/14394003/diff/1/pkg/scheduled_test/lib/src/sc...
File pkg/scheduled_test/lib/src/schedule.dart (right):

https://codereview.chromium.org/14394003/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/schedule.dart:76: List<ScheduleError> get errors =>
Is it worth exposing UnmodifiableListView in the type annotation so that callers
know they cannot modify it?

https://codereview.chromium.org/14394003/diff/1/pkg/stack_trace/lib/src/trace...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/14394003/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:66: : frames = new
UnmodifiableListView<Frame>(frames);
If the original parameter list is modified, do we want the Trace object to
reflect that? If not, we should copy here.

[nweiz, 2013-04-22 22:46:40]

https://codereview.chromium.org/14394003/diff/1/pkg/scheduled_test/lib/src/sc...
File pkg/scheduled_test/lib/src/schedule.dart (right):

https://codereview.chromium.org/14394003/diff/1/pkg/scheduled_test/lib/src/sc...
pkg/scheduled_test/lib/src/schedule.dart:76: List<ScheduleError> get errors =>
On 2013/04/22 22:11:40, Bob Nystrom wrote:
> Is it worth exposing UnmodifiableListView in the type annotation so that
callers
> know they cannot modify it?

I don't think so. I want the flexibility to swap out the implementation of these
fields without changing the API.

https://codereview.chromium.org/14394003/diff/1/pkg/stack_trace/lib/src/trace...
File pkg/stack_trace/lib/src/trace.dart (right):

https://codereview.chromium.org/14394003/diff/1/pkg/stack_trace/lib/src/trace...
pkg/stack_trace/lib/src/trace.dart:66: : frames = new
UnmodifiableListView<Frame>(frames);
On 2013/04/22 22:11:40, Bob Nystrom wrote:
> If the original parameter list is modified, do we want the Trace object to
> reflect that? If not, we should copy here.

Done.

[Bob Nystrom, 2013-04-22 22:50:21]

LGTM, though I wish we had an immutable list interface we could use so callers
can tell up front that certain methods will throw.

[nweiz, 2013-04-22 23:05:42]

Committed patchset #2 manually as r21855 (presubmit successful).