Issue 14367005: Improved error messages for type mismatches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14367005: Improved error messages for type mismatches. (Closed)

Created:
7 years, 8 months ago by gram

Modified:
7 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improved error messages for type mismatches. Committed: https://code.google.com/p/dart/source/detail?r=21774

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -18 lines)			Patch
	M	pkg/unittest/lib/src/core_matchers.dart	View		2 chunks	+5 lines, -3 lines	0 comments	Download
	M	pkg/unittest/test/matchers_test.dart	View		2 chunks	+20 lines, -15 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm! https://codereview.chromium.org/14367005/diff/1/pkg/unittest/test/matchers_test.dart File pkg/unittest/test/matchers_test.dart (right): https://codereview.chromium.org/14367005/diff/1/pkg/unittest/test/matchers_test.dart#newcode243 pkg/unittest/test/matchers_test.dart:243: " but: was .*:'error' \$not type .*\$\.\$")); now ...

7 years, 8 months ago (2013-04-19 17:18:23 UTC) #2

gram

7 years, 8 months ago (2013-04-19 21:23:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21774 (presubmit successful).

Expand Messages | Collapse Messages