Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 14366024: Add fallback to load the original version of dart:io library (Closed)

Created:
7 years, 8 months ago by podivilov
Modified:
7 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add fallback to load the original version of dart:io library if url mapping is not provided. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=21892

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
podivilov
7 years, 8 months ago (2013-04-19 16:51:30 UTC) #1
siva
https://codereview.chromium.org/14366024/diff/1/runtime/bin/gen_snapshot.cc File runtime/bin/gen_snapshot.cc (right): https://codereview.chromium.org/14366024/diff/1/runtime/bin/gen_snapshot.cc#newcode311 runtime/bin/gen_snapshot.cc:311: } Not sure if I understand this. The comment ...
7 years, 8 months ago (2013-04-19 17:47:50 UTC) #2
podivilov
PTAL. https://codereview.chromium.org/14366024/diff/1/runtime/bin/gen_snapshot.cc File runtime/bin/gen_snapshot.cc (right): https://codereview.chromium.org/14366024/diff/1/runtime/bin/gen_snapshot.cc#newcode311 runtime/bin/gen_snapshot.cc:311: } On 2013/04/19 17:47:50, siva wrote: > Not ...
7 years, 8 months ago (2013-04-20 07:34:21 UTC) #3
podivilov
ping
7 years, 8 months ago (2013-04-23 07:36:38 UTC) #4
siva
lgtm
7 years, 8 months ago (2013-04-23 16:19:09 UTC) #5
podivilov
7 years, 8 months ago (2013-04-23 16:26:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r21892 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698