Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 143643002: Be more aggressive when inlining getters and setters (we assume they are typically simple, efficien… (Closed)

Created:
6 years, 11 months ago by srdjan
Modified:
6 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org, john_johnmccutchan.com
Visibility:
Public.

Description

Be more aggressive when inlining getters and setters (we assume they are typically simple, efficient functions). +15% on Box2D. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=31961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/vm/intermediate_language.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
6 years, 11 months ago (2014-01-20 22:04:50 UTC) #1
Florian Schneider
LGTM.
6 years, 11 months ago (2014-01-21 10:49:59 UTC) #2
srdjan
6 years, 11 months ago (2014-01-21 17:44:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698