Make mock_compiler initialize the identical function, and use the identical function element direct…

Make mock_compiler initialize the identical function, and use the identical function element directly in the simple inferrer.

Committed: https://code.google.com/p/dart/source/detail?r=21730

[ngeoffray, 2013-04-19 09:28:57]

I was surprised that identicalFunction could be null, and it turns out it's the
mock_compiler again...

[erikcorry, 2013-04-19 09:40:48]

LGTM

https://codereview.chromium.org/14362026/diff/3003/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/14362026/diff/3003/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:622:
&& returnType != returnTypeOf[analyzedElement.implementation]) {
It's confusing to write ".implementation" here even if it makes no difference,
because internalRecordType does not use ".implementation" when updating
returnTypeOf (which it calls 'types').

https://codereview.chromium.org/14362026/diff/3003/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:623:
// One of the functions turned out not to return
Strange formatting of comment.

[ngeoffray, 2013-04-19 09:46:20]

Thanks Erik

https://codereview.chromium.org/14362026/diff/3003/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/14362026/diff/3003/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:300:
return element == compiler.identicalFunction
Changed that to be identicalFunction.implementation. Right now it's the same
element, but you never know...

https://codereview.chromium.org/14362026/diff/3003/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:622:
&& returnType != returnTypeOf[analyzedElement.implementation]) {
On 2013/04/19 09:40:48, erikcorry wrote:
> It's confusing to write ".implementation" here even if it makes no difference,
> because internalRecordType does not use ".implementation" when updating
> returnTypeOf (which it calls 'types').

Done. And I added an assert.

https://codereview.chromium.org/14362026/diff/3003/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:623:
// One of the functions turned out not to return
On 2013/04/19 09:40:48, erikcorry wrote:
> Strange formatting of comment.

Done.

[ngeoffray, 2013-04-19 09:54:02]

Committed patchset #2 manually as r21730 (presubmit successful).