Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 14362008: Implement catch on ARM. (Closed)

Created:
7 years, 8 months ago by regis
Modified:
7 years, 8 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement catch on ARM. Enabled UnhandledExceptions vm test. Minor clean up. Committed: https://code.google.com/p/dart/source/detail?r=21708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -49 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/exceptions_test.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 4 chunks +32 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 8 months ago (2013-04-18 21:49:00 UTC) #1
zra
lgtm
7 years, 8 months ago (2013-04-18 22:14:02 UTC) #2
regis
7 years, 8 months ago (2013-04-18 22:19:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21708 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698