Re-enables ARM cross-compile.

Re-enables ARM cross-compile.

Overriding the 'product_dir' of target libdart_dependency_helper
was previously removed because of a build failure of Dartium on
Mac when building with ninja. Removal of this override caused
the ARM cross-compile to fail.

The change here achieves the same end as the 'product_dir'
override by creating two separate targets for the host and
target architectures, and works on Mac and Linux with
ninja and make.

R=iposva@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22139

[Ivan Posva, 2013-04-26 20:10:51]

LGTM -ip

[kustermann, 2013-04-29 09:29:57]

lgtm

Sorry I didn't see this on Friday (it was a danish holiday).

https://codereview.chromium.org/14359014/diff/1/runtime/dart-runtime.gyp
File runtime/dart-runtime.gyp (right):

https://codereview.chromium.org/14359014/diff/1/runtime/dart-runtime.gyp#newc...
runtime/dart-runtime.gyp:127: ],
You could make a variable containing these dependencies, so we don't have
duplication here.
But if this list doesn't change, I'm happy with this as well.

[kustermann, 2013-04-29 10:04:30]

One more note: I saw that the 'LIB_DIR' variable is not available on
ninja+windows. A while back, I did setup a 'dartium-win-inc-ninja' builder on
FYI. Since your gyp changes it is broken, because 'LIB_DIR' is not available.
(looking into the gyp sources: it's just not set on windows).

For now we don't need to use ninja on windows -- but the time may come.

On 2013/04/29 09:29:57, kustermann wrote:
> lgtm
> 
> Sorry I didn't see this on Friday (it was a danish holiday).
> 
> https://codereview.chromium.org/14359014/diff/1/runtime/dart-runtime.gyp
> File runtime/dart-runtime.gyp (right):
> 
>
https://codereview.chromium.org/14359014/diff/1/runtime/dart-runtime.gyp#newc...
> runtime/dart-runtime.gyp:127: ],
> You could make a variable containing these dependencies, so we don't have
> duplication here.
> But if this list doesn't change, I'm happy with this as well.

[zra, 2013-04-29 18:38:18]

I've added a TODO that this will have to change later. In the meantime I'll try
a few things, and submit another CL if I find something that works.

On 2013/04/29 10:04:30, kustermann wrote:
> One more note: I saw that the 'LIB_DIR' variable is not available on
> ninja+windows. A while back, I did setup a 'dartium-win-inc-ninja' builder on
> FYI. Since your gyp changes it is broken, because 'LIB_DIR' is not available.
> (looking into the gyp sources: it's just not set on windows).
> 
> For now we don't need to use ninja on windows -- but the time may come.

[zra, 2013-04-29 18:38:35]

https://codereview.chromium.org/14359014/diff/1/runtime/dart-runtime.gyp
File runtime/dart-runtime.gyp (right):

https://codereview.chromium.org/14359014/diff/1/runtime/dart-runtime.gyp#newc...
runtime/dart-runtime.gyp:127: ],
On 2013/04/29 09:29:57, kustermann wrote:
> You could make a variable containing these dependencies, so we don't have
> duplication here.
> But if this list doesn't change, I'm happy with this as well.

Done.

[zra, 2013-04-29 18:39:09]

Committed patchset #2 manually as r22139 (presubmit successful).