Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 1435893005: Mark analyzer summary_test as slow. (Closed)

Created:
5 years, 1 month ago by Bill Hesse
Modified:
5 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase from August to November #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/pkg.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
5 years, 1 month ago (2015-11-12 09:27:07 UTC) #2
Søren Gjesse
lgtm
5 years, 1 month ago (2015-11-12 09:41:54 UTC) #3
Bill Hesse
Committed patchset #2 (id:20001) manually as ebf8830dd2e9e2188288321e7afa5e23ce768bdb (presubmit successful).
5 years, 1 month ago (2015-11-13 16:49:02 UTC) #4
Paul Berry
5 years, 1 month ago (2015-11-13 18:53:48 UTC) #5
Message was sent while issue was closed.
On 2015/11/13 16:49:02, Bill Hesse wrote:
> Committed patchset #2 (id:20001) manually as
> ebf8830dd2e9e2188288321e7afa5e23ce768bdb (presubmit successful).

Thanks for dealing with this--I was out sick yesterday and couldn't fix it
myself.

I've investigated more deeply and I suspect that the root cause is a dart2js
bug, so I've filed https://github.com/dart-lang/sdk/issues/24914 to make sure
this doesn't get forgotten about.

Powered by Google App Engine
This is Rietveld 408576698