Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 143473006: Send error-event if socket is marked for error. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen
Modified:
6 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Send error-event if socket is marked for error. BUG=http://code.google.com/p/dart/issues/detail?id=16544

Patch Set 1 #

Total comments: 1

Patch Set 2 : Really fix the issue :) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/bin/eventhandler_win.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 10 months ago (2014-02-05 11:37:02 UTC) #1
Søren Gjesse
Are you sure this is the right way? Whether shutdown is issued or not should ...
6 years, 10 months ago (2014-02-05 11:55:15 UTC) #2
Søren Gjesse
6 years, 10 months ago (2014-02-06 14:31:14 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698