Issue 14341012: Fix another unused-private-field clang error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14341012: Fix another unused-private-field clang error. (Closed)

Created:
7 years, 8 months ago by tfarina

Modified:
7 years, 8 months ago

Reviewers:
Kevin Millikin (Chromium), Kevin Millikin (Google)

CC:
reviews_dartlang.org, siva, Ivan Posva

Base URL:
https://git.chromium.org/git/external/dart/bleeding_edge.git@master

Visibility:
Public.

Fix another unused-private-field clang error. ../../runtime/vm/intermediate_language.h:1093:20: error: private field 'block_entry_' is not used [-Werror,-Wunused-private-field] BlockEntryInstr* block_entry_; R=kmillikin@google.com Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: https://code.google.com/p/dart/source/detail?r=21876

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	dart/runtime/vm/intermediate_language.h	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

tfarina

Resending to his chromium address. Not sure which one is preferred though.

7 years, 8 months ago (2013-04-23 01:14:33 UTC) #2

Kevin Millikin (Google)

LGTM, I will commit. Google contributors to the Dart project use their @google.com email addresses.

7 years, 8 months ago (2013-04-23 12:38:15 UTC) #3

Kevin Millikin (Google)

7 years, 8 months ago (2013-04-23 12:39:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21876 (presubmit successful).