Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143403006: Print options when given no arguments instead of crashing (Closed)

Created:
6 years, 10 months ago by Alan Knight
Modified:
6 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Print options when given no arguments instead of crashing BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=32290

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M pkg/docgen/bin/docgen.dart View 1 3 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alan Knight
6 years, 10 months ago (2014-02-04 19:44:41 UTC) #1
Emily Fortuna
https://codereview.chromium.org/143403006/diff/1/pkg/docgen/bin/docgen.dart File pkg/docgen/bin/docgen.dart (right): https://codereview.chromium.org/143403006/diff/1/pkg/docgen/bin/docgen.dart#newcode15 pkg/docgen/bin/docgen.dart:15: ArgParser argParser = _initArgParser(); why move this out as ...
6 years, 10 months ago (2014-02-04 20:40:03 UTC) #2
Alan Knight
https://codereview.chromium.org/143403006/diff/1/pkg/docgen/bin/docgen.dart File pkg/docgen/bin/docgen.dart (right): https://codereview.chromium.org/143403006/diff/1/pkg/docgen/bin/docgen.dart#newcode15 pkg/docgen/bin/docgen.dart:15: ArgParser argParser = _initArgParser(); On 2014/02/04 20:40:03, Emily Fortuna ...
6 years, 10 months ago (2014-02-04 20:48:06 UTC) #3
Emily Fortuna
lgtm
6 years, 10 months ago (2014-02-04 20:57:04 UTC) #4
Alan Knight
6 years, 10 months ago (2014-02-04 21:22:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r32290 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698