First pass at cleaning up html lib warnings from the analyzer.

First pass at cleaning up html lib warnings from the analyzer.

BUG=
R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32377

[Emily Fortuna, 2014-02-06 01:38:16]

more warnings to fix, but it's a start.

https://codereview.chromium.org/143363011/diff/20001/sdk/lib/_internal/lib/co...
File sdk/lib/_internal/lib/constant_map.dart (right):

https://codereview.chromium.org/143363011/diff/20001/sdk/lib/_internal/lib/co...
sdk/lib/_internal/lib/constant_map.dart:28: final int length = 0;
not sure why fixing this file our problem, but it was an error that showed up
since html uses this file, so I'm fixing it anyway.

[blois, 2014-02-06 16:57:32]

https://codereview.chromium.org/143363011/diff/20001/sdk/lib/_internal/lib/co...
File sdk/lib/_internal/lib/constant_map.dart (right):

https://codereview.chromium.org/143363011/diff/20001/sdk/lib/_internal/lib/co...
sdk/lib/_internal/lib/constant_map.dart:28: final int length = 0;
On 2014/02/06 01:38:16, Emily Fortuna wrote:
> not sure why fixing this file our problem, but it was an error that showed up
> since html uses this file, so I'm fixing it anyway.

I'd probably split this one out to a separate CL. Also to maintain current
behavior, length would be initialized to null (not sure what the intent is
though.

https://codereview.chromium.org/143363011/diff/20001/sdk/lib/_internal/lib/js...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/143363011/diff/20001/sdk/lib/_internal/lib/js...
sdk/lib/_internal/lib/js_helper.dart:2698: if (inAssert) return null;
Odd that this is an error. Still, I'd suggest a separate CL.

https://codereview.chromium.org/143363011/diff/20001/tools/dom/src/EventStrea...
File tools/dom/src/EventStreamProvider.dart (right):

https://codereview.chromium.org/143363011/diff/20001/tools/dom/src/EventStrea...
tools/dom/src/EventStreamProvider.dart:227: if (_canceled) return null;
Should return new Future.value(null).

[Emily Fortuna, 2014-02-06 18:39:00]

https://codereview.chromium.org/143363011/diff/20001/tools/dom/src/EventStrea...
File tools/dom/src/EventStreamProvider.dart (right):

https://codereview.chromium.org/143363011/diff/20001/tools/dom/src/EventStrea...
tools/dom/src/EventStreamProvider.dart:227: if (_canceled) return null;
On 2014/02/06 16:57:32, blois wrote:
> Should return new Future.value(null).

Does this mean the docs for this method should be changed?
https://dartdoc-next-dot-dartlang-api.appspot.com/apidocs/channels/be/#dart-a...
I was following that.

[blois, 2014-02-06 18:54:26]

https://codereview.chromium.org/143363011/diff/20001/tools/dom/src/EventStrea...
File tools/dom/src/EventStreamProvider.dart (right):

https://codereview.chromium.org/143363011/diff/20001/tools/dom/src/EventStrea...
tools/dom/src/EventStreamProvider.dart:227: if (_canceled) return null;
On 2014/02/06 18:39:00, Emily Fortuna wrote:
> On 2014/02/06 16:57:32, blois wrote:
> > Should return new Future.value(null).
> 
> Does this mean the docs for this method should be changed?
>
https://dartdoc-next-dot-dartlang-api.appspot.com/apidocs/channels/be/#dart-a...
> I was following that.

Ah! I was only looking at the implementation. Looks good.

[Emily Fortuna, 2014-02-06 19:02:06]

ptal

[blois, 2014-02-06 19:06:14]

lgtm

[Emily Fortuna, 2014-02-06 19:12:34]

Committed patchset #3 manually as r32377 (presubmit successful).