Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 14333023: The matcher argument to the CustomMatcher constructor no longer has to be a matcher; it will be wra… (Closed)

Created:
7 years, 8 months ago by gram
Modified:
7 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

The matcher argument to the CustomMatcher constructor no longer has to be a matcher; it will be wrapped if not. Addresses https://code.google.com/p/dart/issues/detail?id=9924 Committed: https://code.google.com/p/dart/source/detail?r=21975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/unittest/lib/src/core_matchers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/unittest/test/matchers_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 8 months ago (2013-04-24 19:57:21 UTC) #1
nweiz
lgtm!
7 years, 8 months ago (2013-04-24 20:01:20 UTC) #2
gram
7 years, 8 months ago (2013-04-24 20:19:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21975 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698