Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 143243005: pkg/collection: mark fields in wrappers as final (Closed)

Created:
6 years, 11 months ago by kevmoo
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/collection: mark fields in wrappers as final R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=32173

Patch Set 1 #

Patch Set 2 : bumped pubspec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pkg/collection/lib/wrappers.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/collection/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
6 years, 11 months ago (2014-01-24 20:21:35 UTC) #1
kevmoo
tiny...PTAL
6 years, 10 months ago (2014-01-30 00:44:40 UTC) #2
Lasse Reichstein Nielsen
(base file upload failed, but unified diff looks ok) Remember to update the version number ...
6 years, 10 months ago (2014-01-30 09:44:14 UTC) #3
kevmoo
6 years, 10 months ago (2014-01-30 21:19:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r32173 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698