Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 14322011: Add access to process id for both current process and processes started (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add access to process id for both current process and processes started BUG=https://code.google.com/p/dart/issues/detail?id=9129 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=21611

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -2 lines) Patch
M runtime/bin/io_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/process.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/bin/process_patch.dart View 5 chunks +10 lines, -2 lines 2 comments Download
M sdk/lib/io/process.dart View 4 chunks +16 lines, -0 lines 2 comments Download
A tests/standalone/io/process_pid_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 8 months ago (2013-04-17 08:59:25 UTC) #1
Anders Johnsen
LGTM! https://codereview.chromium.org/14322011/diff/1/runtime/bin/process_patch.dart File runtime/bin/process_patch.dart (right): https://codereview.chromium.org/14322011/diff/1/runtime/bin/process_patch.dart#newcode332 runtime/bin/process_patch.dart:332: const _ProcessResult(int this.pid, I'm not sure it makes ...
7 years, 8 months ago (2013-04-17 09:13:06 UTC) #2
Søren Gjesse
https://codereview.chromium.org/14322011/diff/1/runtime/bin/process_patch.dart File runtime/bin/process_patch.dart (right): https://codereview.chromium.org/14322011/diff/1/runtime/bin/process_patch.dart#newcode332 runtime/bin/process_patch.dart:332: const _ProcessResult(int this.pid, On 2013/04/17 09:13:06, Anders Johnsen wrote: ...
7 years, 8 months ago (2013-04-17 10:15:12 UTC) #3
Søren Gjesse
7 years, 8 months ago (2013-04-17 10:15:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21611 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698