Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1432143003: Update the tests to run with Dart 1.13. (Closed)

Created:
5 years, 1 month ago by Søren Gjesse
Modified:
5 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/http_server.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update the tests to run with Dart 1.13. Used a copy of the certificates we use for testing in the Dart SDK. This does not affect the dart SDK supported by the package itself. BUG= https://github.com/dart-lang/http_server/issues/31 R=whesse@google.com Committed: https://github.com/dart-lang/http_server/commit/3ed8c55b96fad5854a6d0bc419c446ee0f84303a

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -6 lines) Patch
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/certificates/server_chain.pem View 1 chunk +59 lines, -0 lines 0 comments Download
A test/certificates/server_key.pem View 1 chunk +29 lines, -0 lines 0 comments Download
A test/certificates/trusted_certs.pem View 1 chunk +18 lines, -0 lines 0 comments Download
M test/utils.dart View 1 3 chunks +18 lines, -4 lines 0 comments Download
M test/virtual_host_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
5 years, 1 month ago (2015-11-11 16:46:45 UTC) #1
Bill Hesse
lgtm https://codereview.chromium.org/1432143003/diff/1/test/utils.dart File test/utils.dart (right): https://codereview.chromium.org/1432143003/diff/1/test/utils.dart#newcode91 test/utils.dart:91: if (secure) print(clientContext); Debug printing? Does a context ...
5 years, 1 month ago (2015-11-11 17:43:22 UTC) #2
Søren Gjesse
https://codereview.chromium.org/1432143003/diff/1/test/utils.dart File test/utils.dart (right): https://codereview.chromium.org/1432143003/diff/1/test/utils.dart#newcode91 test/utils.dart:91: if (secure) print(clientContext); On 2015/11/11 17:43:22, Bill Hesse wrote: ...
5 years, 1 month ago (2015-11-12 07:37:30 UTC) #3
Søren Gjesse
5 years, 1 month ago (2015-11-12 07:38:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3ed8c55b96fad5854a6d0bc419c446ee0f84303a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698