Detect leaf optimized methods and skip stack check overflow test in those, unless it is in a loop (…

Detect leaf optimized methods and skip stack check overflow test in those, unless it is in a loop (to be able to stop it).

Committed: https://code.google.com/p/dart/source/detail?r=21692

[Kevin Millikin (Google), 2013-04-18 10:05:28]

LGTM.

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler.cc:202: BlockEntryInstr* entry = block_order_[1];
I don't think we should rely on properties of the block order here (i.e., we
might want to reorder blocks).

The simplest way to avoid it is to have the FlowGraphCompiler hold onto the flow
graph so you can write

Instruction* entry = flow_graph_->normal_entry();

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/intermediate_la...
runtime/vm/intermediate_language.cc:1514: // Nothing to do. Context register
were loaded by register allocator.
I like the space.  If you're going to make a change to this line, you could also
change 'were' to 'was' or 'is' and add the article 'the' before register
allocator.  :)

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_arm.cc:68: new LocationSummary(kNumInputs,
kNumTemps, LocationSummary::kNoCall);
Good catch.

[srdjan, 2013-04-18 18:15:57]

Thanks

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler.cc:202: BlockEntryInstr* entry = block_order_[1];
On 2013/04/18 10:05:28, kmillikin wrote:
> I don't think we should rely on properties of the block order here (i.e., we
> might want to reorder blocks).
> 
> The simplest way to avoid it is to have the FlowGraphCompiler hold onto the
flow
> graph so you can write
> 
> Instruction* entry = flow_graph_->normal_entry();

Yes, using: flow_graph_.graph_entry()->normal_entry()->next()

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/14308009/diff/7003/runtime/vm/intermediate_la...
runtime/vm/intermediate_language.cc:1514: // Nothing to do. Context register
were loaded by register allocator.
On 2013/04/18 10:05:28, kmillikin wrote:
> I like the space.  If you're going to make a change to this line, you could
also
> change 'were' to 'was' or 'is' and add the article 'the' before register
> allocator.  :)

Added space back, changed were to was and added the.

[srdjan, 2013-04-18 18:37:33]

Committed patchset #4 manually as r21692 (presubmit successful).