Issue 14298002: Deprecate old debugger breakpoint handler

Issue 14298002: Deprecate old debugger breakpoint handler (Closed)

Created:
7 years, 8 months ago by hausner

Modified:
7 years, 8 months ago

Reviewers:
Tom Ball

CC:
reviews_dartlang.org, podivilov1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Deprecate old debugger breakpoint handler - Add new breakpoint handler callback that does not take a stack trace - Remove deprecated handler from debugger core - Adjust tests - Old breakpoint handler support remain in code until Dartium switches to new handler. Committed: https://code.google.com/p/dart/source/detail?r=21569

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -84 lines)			Patch
M	runtime/bin/dbg_message.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	runtime/bin/dbg_message.cc	View		3 chunks	+12 lines, -9 lines	0 comments	Download
M	runtime/include/dart_debugger_api.h	View	1	4 chunks	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/debugger.cc	View		3 chunks	+6 lines, -31 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View		2 chunks	+33 lines, -9 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View		20 chunks	+41 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tom Ball

lgtm, with a couple of nits. https://codereview.chromium.org/14298002/diff/1/runtime/bin/dbg_message.cc File runtime/bin/dbg_message.cc (right): https://codereview.chromium.org/14298002/diff/1/runtime/bin/dbg_message.cc#newcode992 runtime/bin/dbg_message.cc:992: msg.Printf("\"tokenOffset\":%d}", location.token_pos); Should ...

7 years, 8 months ago (2013-04-16 18:50:35 UTC) #2

hausner

Committed patchset #2 manually as r21569 (presubmit successful).

7 years, 8 months ago (2013-04-16 19:42:45 UTC) #3

hausner

7 years, 8 months ago (2013-04-18 00:02:39 UTC) #4

Message was sent while issue was closed.

Better late than never...

https://codereview.chromium.org/14298002/diff/1/runtime/bin/dbg_message.cc
File runtime/bin/dbg_message.cc (right):

https://codereview.chromium.org/14298002/diff/1/runtime/bin/dbg_message.cc#ne...
runtime/bin/dbg_message.cc:992: msg.Printf("\"tokenOffset\":%d}",
location.token_pos);
On 2013/04/16 18:50:35, Tom Ball wrote:
> Should these be %Pd?
I defined the token_pos member of Dart_CodeLocation as int32_t, so %d is fine.

https://codereview.chromium.org/14298002/diff/1/runtime/include/dart_debugger...
File runtime/include/dart_debugger_api.h (right):

https://codereview.chromium.org/14298002/diff/1/runtime/include/dart_debugger...
runtime/include/dart_debugger_api.h:28: // DEPRECATED -- use
Dart_PauesedEventHandler
On 2013/04/16 18:50:35, Tom Ball wrote:
> sb Dart_PausedEventHandler

Must be my accent :)

Expand Messages | Collapse Messages