Issue 14289002: Make JSON stringify throw a JsonUnsupportedObjectError on cycles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14289002: Make JSON stringify throw a JsonUnsupportedObjectError on cycles. (Closed)

Created:
7 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 8 months ago

Reviewers:
floitsch, Anders Johnsen

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make JSON stringify throw a JsonUnsupportedObjectError on cycles. Add lib/json test based on tests/json/json_test.dart (is this used at all?). Committed: https://code.google.com/p/dart/source/detail?r=21538

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -21 lines)			Patch
	M	sdk/lib/json/json.dart	View		5 chunks	+28 lines, -9 lines	0 comments	Download
	A +	tests/lib/json/json_test.dart	View		5 chunks	+39 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

7 years, 8 months ago (2013-04-16 08:13:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21538 (presubmit successful).

Expand Messages | Collapse Messages