Issue 14288006: Inline Float32x4 comparison.

Issue 14288006: Inline Float32x4 comparison. (Closed)

Created:
7 years, 7 months ago by Cutch

Modified:
7 years, 7 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Inline Float32x4 comparison. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22144

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+605 lines, -3 lines)			Patch
M	runtime/vm/flow_graph_compiler.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	4 chunks	+64 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		7 chunks	+121 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		2 chunks	+33 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		3 chunks	+152 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		2 chunks	+33 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		2 chunks	+138 lines, -1 line	0 comments	Download
M	tests/lib/typed_data/float32x4_unbox_regress_test.dart	View		1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

Inline Float32x4 comparison operations. Support for unboxed Uint32x4 instances. Modify UnboxFloat32x4 to check for class.

7 years, 7 months ago (2013-04-29 18:02:20 UTC) #1

Cutch

$ ./tools/test.py -m all -a all --checked Test configurations: none_vm_debug_ia32_checked none_vm_release_ia32_checked none_vm_debug_x64_checked none_vm_release_x64_checked none_vm_debug_simarm_checked none_vm_release_simarm_checked ...

7 years, 7 months ago (2013-04-29 18:16:45 UTC) #2

srdjan

LGTM https://codereview.chromium.org/14288006/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/14288006/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1740 runtime/vm/flow_graph_optimizer.cc:1740: if ((class_ids[0] == kFloat32x4Cid) &&(ic_data.NumberOfChecks() == 1)) { ...

7 years, 7 months ago (2013-04-29 18:25:53 UTC) #3

Cutch

7 years, 7 months ago (2013-04-29 19:17:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22144 (presubmit successful).

Expand Messages | Collapse Messages