Issue 1427523005: "pub global run" errors out for a mismatched SDK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1427523005: "pub global run" errors out for a mismatched SDK. (Closed)

Created:
5 years, 1 month ago by nweiz

Modified:
5 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

"pub global run" errors out for a mismatched SDK. Previously, "pub global run" would happily try to run an executable with an SDK constraint that doesn't match the current SDK, even though it probably wouldn't work (and could fail in confusing ways). Now it errors out with a user-friendly message instead. Closes #1353 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/0636b17d13270f2ee0b7e05c014a14a586cce870

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -73 lines)			Patch
M	lib/src/global_packages.dart	View	1 chunk	+16 lines, -6 lines	0 comments	Download
A +	test/global/run/fails_if_sdk_constraint_is_unmet_test.dart	View	2 chunks	+15 lines, -18 lines	0 comments	Download
D	test/global/run/recompiles_if_sdk_is_out_of_date_test.dart	View	1 chunk	+0 lines, -48 lines	0 comments	Download
A +	test/global/run/recompiles_if_snapshot_is_out_of_date_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

5 years, 1 month ago (2015-10-28 21:49:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0636b17d13270f2ee0b7e05c014a14a586cce870 (presubmit successful).

Expand Messages | Collapse Messages