Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Issue 14273021: Report OOM errors instead of asserting on allocation failures when sending (Closed)

Created:
7 years, 8 months ago by siva
Modified:
7 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report OOM errors instead of asserting on allocation failures when sending messages to other isolates. Committed: https://code.google.com/p/dart/source/detail?r=21980

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -20 lines) Patch
M runtime/vm/datastream.h View 1 3 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/exceptions.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 5 chunks +14 lines, -1 line 0 comments Download
M runtime/vm/snapshot.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 6 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
7 years, 8 months ago (2013-04-23 01:16:01 UTC) #1
hausner
LGTM
7 years, 8 months ago (2013-04-23 15:18:10 UTC) #2
siva
I had to change SetWriteException a bit as a test was failing. PTAL.
7 years, 8 months ago (2013-04-24 19:51:28 UTC) #3
hausner
Still LGTM
7 years, 8 months ago (2013-04-24 20:05:53 UTC) #4
siva
7 years, 8 months ago (2013-04-24 20:52:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21980 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698