Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1426973002: Get rid of an unused library. (Closed)

Created:
5 years, 1 month ago by nweiz
Modified:
5 years, 1 month ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
D lib/src/runner/load_exception_suite.dart View 1 chunk +0 lines, -31 lines 0 comments Download
M test/frontend/set_up_all_test.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/runner/engine_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 1 month ago (2015-10-29 00:37:39 UTC) #1
kevmoo
While you're doing cleanup, remove unused imports from some test libs find test -name *_test.dart ...
5 years, 1 month ago (2015-10-29 00:44:03 UTC) #2
nweiz
Code review changes
5 years, 1 month ago (2015-10-29 00:52:34 UTC) #3
nweiz
On 2015/10/29 00:44:03, kevmoo wrote: > While you're doing cleanup, remove unused imports from some ...
5 years, 1 month ago (2015-10-29 00:52:36 UTC) #4
nweiz
5 years, 1 month ago (2015-10-29 00:52:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f0bf655d5efd9a4669186f28144c213fbbd0f4d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698