Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 14266009: pkg/unittest: Included traces in more places (Closed)

Created:
7 years, 8 months ago by kevmoo-old
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/unittest: Included traces in more places when the rest returns as a future when test setup is a future and fails Committed: https://code.google.com/p/dart/source/detail?r=21915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M pkg/unittest/lib/src/test_case.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/unittest/lib/unittest.dart View 9 chunks +19 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo-old
I was noticing very quiet error output in some cases...that all happened to be async ...
7 years, 8 months ago (2013-04-24 00:40:43 UTC) #1
gram
lgtm
7 years, 8 months ago (2013-04-24 00:56:24 UTC) #2
kevmoo-old
7 years, 8 months ago (2013-04-24 00:58:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698