Issue 14263014: Triage feature defines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14263014: Triage feature defines. (Closed)

Created:
7 years, 8 months ago by Anton Muhin

Modified:
7 years, 8 months ago

Reviewers:
Mads Ager (google), blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Triage feature defines. R=ager@google.com, blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=21487

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
	M	tools/dom/scripts/fremontcutbuilder.py	View		1 chunk	+8 lines, -9 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM https://codereview.chromium.org/14263014/diff/1/tools/dom/scripts/fremontcutbuilder.py File tools/dom/scripts/fremontcutbuilder.py (right): https://codereview.chromium.org/14263014/diff/1/tools/dom/scripts/fremontcutbuilder.py#newcode29 tools/dom/scripts/fremontcutbuilder.py:29: 'ENABLE_VIDEO_TRACK ', # Sic! With the trailing space. ...

7 years, 8 months ago (2013-04-15 17:42:28 UTC) #2

Anton Muhin

https://codereview.chromium.org/14263014/diff/1/tools/dom/scripts/fremontcutbuilder.py File tools/dom/scripts/fremontcutbuilder.py (right): https://codereview.chromium.org/14263014/diff/1/tools/dom/scripts/fremontcutbuilder.py#newcode29 tools/dom/scripts/fremontcutbuilder.py:29: 'ENABLE_VIDEO_TRACK ', # Sic! With the trailing space. On ...

7 years, 8 months ago (2013-04-15 17:43:52 UTC) #3

Anton Muhin

Committed patchset #1 manually as r21487 (presubmit successful).

7 years, 8 months ago (2013-04-15 17:45:17 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages