Issue 14261016: Import io.dart in pub.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14261016: Import io.dart in pub.dart. (Closed)

Created:
7 years, 8 months ago by nweiz

Modified:
7 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Import io.dart in pub.dart. Committed: https://code.google.com/p/dart/source/detail?r=21994

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	sdk/lib/_internal/pub/bin/pub.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r21994 (presubmit successful).

7 years, 8 months ago (2013-04-24 22:27:46 UTC) #2

nweiz

7 years, 8 months ago (2013-04-24 22:33:36 UTC) #4

Message was sent while issue was closed.

On 2013/04/24 22:32:35, Bob Nystrom wrote:
> LGTM.
> 
> This didn't get caught by tests?

It's only used on Windows to check if the user is running XP. It got caught by
the tests, but only on the bots.

Expand Messages | Collapse Messages