Issue 14261003: Don't delay IOSink.close() with no subscription to the next instance.

Issue 14261003: Don't delay IOSink.close() with no subscription to the next instance. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen

Modified:
7 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't delay IOSink.close() with no subscription to the next instance. This fixes the issue with pub I found. Added TODO in pub, as stdout/stderr doesn't really need wrapping anymore. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21431

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix typo. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
	M	sdk/lib/io/io_sink.dart	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download
	M	utils/pub/io.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/14261003/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/14261003/diff/1/utils/pub/io.dart#newcode287 utils/pub/io.dart:287: // TODO: Unrequired wrapper, stdout is not an ...

7 years, 8 months ago (2013-04-15 11:14:41 UTC) #2

Anders Johnsen

Hehe, excellent typo :) Ty, landing. https://codereview.chromium.org/14261003/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/14261003/diff/1/utils/pub/io.dart#newcode287 utils/pub/io.dart:287: // TODO: Unrequired ...

7 years, 8 months ago (2013-04-15 11:20:43 UTC) #3

Anders Johnsen

7 years, 8 months ago (2013-04-15 11:21:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21431 (presubmit successful).

Expand Messages | Collapse Messages