Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1425953002: add tool to check that deferred libraries contain the expected code (Closed)

Created:
5 years, 1 month ago by Harry Terkelsen
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart2js_info.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add tool to check that deferred libraries contain the expected code BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/dart2js_info/commit/95d244963f85bcc6b6dacdda07329b7081b6f1a1

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -4 lines) Patch
M CHANGELOG.md View 2 chunks +5 lines, -3 lines 0 comments Download
M README.md View 3 chunks +47 lines, -0 lines 0 comments Download
A bin/deferred_library_check.dart View 1 1 chunk +144 lines, -0 lines 0 comments Download
M lib/json_info_codec.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pubspec.yaml View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Harry Terkelsen
5 years, 1 month ago (2015-10-28 17:22:43 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1425953002/diff/1/bin/deferred_library_check.dart File bin/deferred_library_check.dart (right): https://codereview.chromium.org/1425953002/diff/1/bin/deferred_library_check.dart#newcode89 bin/deferred_library_check.dart:89: if (!packages.containsKey(packageName)) { might be worth adding a ...
5 years, 1 month ago (2015-10-28 19:57:47 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/1425953002/diff/1/bin/deferred_library_check.dart File bin/deferred_library_check.dart (right): https://codereview.chromium.org/1425953002/diff/1/bin/deferred_library_check.dart#newcode89 bin/deferred_library_check.dart:89: if (!packages.containsKey(packageName)) { On 2015/10/28 19:57:47, Siggi Cherem (dart-lang) ...
5 years, 1 month ago (2015-10-28 20:49:29 UTC) #4
Harry Terkelsen
5 years, 1 month ago (2015-10-28 20:49:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
95d244963f85bcc6b6dacdda07329b7081b6f1a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698